← Back to team overview

maria-developers team mailing list archive

Re: 6c772ae: MDEV-6956:SET STATEMENT default_master_connection = ... has no effect

 

Hi, Sergei!

On 11.03.15 19:03, Sergei Golubchik wrote:
[skip]
diff --git a/sql/sql_yacc.yy b/sql/sql_yacc.yy
index 8025340..8255306 100644
--- a/sql/sql_yacc.yy
+++ b/sql/sql_yacc.yy
@@ -2445,7 +2445,9 @@ optional_connection_name:
            /* empty */
            {
              LEX *lex= thd->lex;
-            lex->mi.connection_name= thd->variables.default_master_connection;
+            lex->mi.connection_name.str= NullS;
+            lex->mi.connection_name.length= 0;
+              //thd->variables.default_master_connection;
you've forgot to remove this commented-out line.
and prefer to use null_lex_str:

     lex->mi.connection_name= null_lex_str;

IMHO NullS is more reliable special pointer then NULL in this case, because NULL can be assigned in some cleanups & Co.

Regards,
Sergei



Follow ups

References