← Back to team overview

maria-developers team mailing list archive

Re: Please review MDEV-7284 INDEX: CREATE OR REPLACE

 

Hi, Alexander!

Ok to push, thanks!

On Mar 23, Alexander Barkov wrote:
> diff --git a/sql/sql_table.cc b/sql/sql_table.cc
> index c4b07ad..4550b10 100644
> --- a/sql/sql_table.cc
> +++ b/sql/sql_table.cc
> @@ -5830,7 +5830,7 @@ static bool is_candidate_key(KEY *key)

could you please update git?
newer versions show the function name on diffs correctly.
I don't know when exactly this was fixed, but 2.2.2 is ok.

>      const char *keyname;
>      while ((key=key_it++))
>      {
> -      if (!key->if_not_exists())
> +      if (!key->if_not_exists() && !key->or_replace())
>          continue;
>        /* If the name of the key is not specified,     */
>        /* let us check the name of the first key part. */

Regards,
Sergei


References