maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sergey!

On May 07, Sergey Vojtovich wrote:
> On Thu, May 07, 2015 at 01:04:24PM +0200, Sergei Golubchik wrote:
> > Hi, Sergey!
> > 
> > On Mar 17, svoj@xxxxxxxxxxx wrote:
> > > revision-id: 93e746afb2d1a23cb933291ad736a20858b5ac3e
> > > parent(s): ccc7297fe94af1129c717f91d31fa075d54a0371
> > > committer: Sergey Vojtovich
> > > branch nick: mariadb
> > > timestamp: 2015-03-17 19:49:04 +0400
> > > message:
> > > 
> > > MDEV-7793 - Race condition between XA COMMIT/ROLLBACK and disconnect
> > > 
> > > XA COMMIT/ROLLBACK of XA transaction owned by different thread may access
> > > freed memory if that thread disconnects at the same time.
> > > 
> > > Also concurrent XA COMMIT/ROLLBACK of recovered XA transaction were not
> > > serialized properly.
> > > 
> > 
> > Why not mark_acquired() here?
> mark_acquired() is intended to acquire RECOVERED elements.

Ok to push, but please mention this in the method comment.

Regards,
Sergei