maria-developers team mailing list archive

Thread
Date

Re: d116e02: MDEV-7945 - THD::enter_stage() takes 0.48% in OLTP RO

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 8 May 2015 20:17:41 +0200
In-reply-to: <20150414142755.C470F2C411C@mail.askmonty.org>
User-agent: Mutt/1.5.23 (2014-03-12)

Hi, Sergey!

On Apr 14, svoj@xxxxxxxxxxx wrote:
> revision-id: d116e028a9545af8bd9eeb03f2ce0e56a9c455f9
> parent(s): 201c985be56f375677df9275d38f18a20cf41029
> committer: Sergey Vojtovich
> branch nick: mariadb
> timestamp: 2015-04-14 17:52:08 +0400
> message:
> 
> MDEV-7945 - THD::enter_stage() takes 0.48% in OLTP RO
> 
> THD::enter_stage() optimizations:
> - stage backup code moved to THD::backup_stage(), saves one condition
> - moved check for "new_stage" out to callers that actually need it
> - remnants of enter_stage() moved to sql_class.h so it can be inlined
> 
> THD::enter_stage() overhead dropped 0.48% -> 0.07%.
> 
> PROFILING::status_change() optimizations:
> - no need to check "status_arg": it is checked by caller anyway
> - no need to check "enabled": !enabled && current is impossible
> - remnants of status_change() moved to sql_profile.h so it can be inlined
> 
> PROFILING::status_change() overhead dropped 0.1% -> out of radar.

ok to push

Regards,
Sergei