← Back to team overview

maria-developers team mailing list archive

Re: [Commits] 7819ddb: MDEV-8192 - THD::set_command() takes 0.05% in OLTP RO


Hi, Sergey!

On May 28, Sergey Vojtovich wrote:
> > 
> > > Call PSI_server::set_thread_command() conditionally: it is cheaper than calling
> > > dummy function when PFS is off (though it adds some overhead when PFS is on).
> > 
> > I'm not sure about it. P_S will be used more and more over time, let's
> > not intentionally penalize it.
> But in fact I don't like this compromise either. There're two good alternatives
> on my mind, both are probably quite complex:
> - package optimized mysqld (no PFS, no profiling, etc)
> - optimize PFS, e.g. PSI_server::set_thread_command() duplicates work of
>   THD::set_command() so we may try to reuse effect of the latter

I would prefer to stick to the upstream PFS code as close as possible.
We cannot do everything.

> Just let me know if you still don't like this so that I can push at least part
> of this patch that we agreed upon.

Yes, please push that.