maria-developers team mailing list archive

[Alexander Barkov <bar@xxxxxxxxxxx>]

Hi Sergei,


On 06/04/2015 08:24 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Jun 04, Alexander Barkov wrote:
> > On 06/04/2015 06:20 PM, Sergei Golubchik wrote:
> > > On Jun 04, Alexander Barkov wrote:
> > > > Please review a joint patch for:
> > > >
> > > > MDEV-7269 mysqlbinlog Don't know how to handle column type=0 meta=0 (0000)#
> > > >
> > > > MDEV-8267 Add /*old*/ comment into I_S.COLUMN_TYPE for old DECIMAL
> > >
> > > Ok to push!
> > >
> > > How does this fix affect MDEV-7268?
> >
> > Do you mean MDEV-7628 ? :)
>
> No, I mean MDEV-7268.
>
> I would like to see that instead of
>
>    Last_Error: Column 3 of table 'weather.lightning' cannot be converted
>    from type 'decimal(0,?)' to type 'decimal(10,7)'
>
> we'll get
>
>    Last_Error: Column 3 of table 'weather.lightning' cannot be converted
>    from type 'decimal(0,?)/*old*/' to type 'decimal(10,7)'
>
> or something like that.

I see. I misunderstood the question.



No. It's a separate code in rpl_utility:

> void show_sql_type(...)
> {
> ...
>   case MYSQL_TYPE_DECIMAL:
>     {
>       CHARSET_INFO *cs= str->charset();
>       uint32 length=
>         cs->cset->snprintf(cs, (char*) str->ptr(), str->alloced_length(),
>                            "decimal(%d,?)", metadata);
>       str->length(length);
>     }
>     break;
> ...
> }

Btw, what do you suggest to do with MDEV-7268?

Should we just fix the warning so the user clearly sees that this is an 
old decimal?



> Regards,
> Sergei