maria-developers team mailing list archive

Thread
Date

Re: b8e26b0: MDEV-363 - Server crashes in intern_plugin_lock on concurrent installing

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Tue, 9 Jun 2015 14:37:18 +0200
In-reply-to: <20150609095819.932542C44CA@mail.askmonty.org>
User-agent: Mutt/1.5.23 (2014-03-12)

Hi, Sergey!

On Jun 09, svoj@xxxxxxxxxxx wrote:
> revision-id: b8e26b04d4ac22e29a78bca68e101176b6ef507a
> parent(s): 08b2e1ae73f6fe055391bf8437b6dff1a889c49c
> committer: Sergey Vojtovich
> branch nick: mariadb
> timestamp: 2015-06-09 13:50:43 +0400
> message:
> 
> MDEV-363 - Server crashes in intern_plugin_lock on concurrent installing
>            semisync plugin and setting rpl_semi_sync_master_enabled
> 
> There was race condition between INSTALL PLUGIN and SET. It was caused by a
> gap in INSTALL PLUGIN when plugin variables were registered but not fully
> initialized. Accessing such variables concurrently may reference uninitialized
> memory, specifically sys_var_pluginvar::plugin.
> 
> Fixed by initializing sys_var_pluginvar::plugin early, before variable is
> registered.

ok to push!

Regards,
Sergei