← Back to team overview

maria-developers team mailing list archive

Re: [Commits] 09eb231: MDEV-8762: file_key_management plugin should be disabled by default when linked statically

 

Hi, Jan!

That's not a good idea. It'd mean that installing a plugin is not
enough, it must be explicitly enabled. I don't see any reason why one
should be forced to do it.

I'll comment in the bugreport.

On Oct 01, Jan Lindström wrote:
> revision-id: 09eb23148830c53e594cfb88dcb31f1b9e42ae5e (mariadb-10.1.7-33-g09eb231)
> parent(s): 3a7cee05d6bac27c3c2f51afb8986c1581649bbc
> committer: Jan Lindström
> timestamp: 2015-10-01 14:27:10 +0300
> message:
> 
> MDEV-8762: file_key_management plugin should be disabled by default when linked statically
> 
> ---
>  sql/sql_plugin.cc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sql/sql_plugin.cc b/sql/sql_plugin.cc
> index 6d8268e..1d2e2d8 100644
> --- a/sql/sql_plugin.cc
> +++ b/sql/sql_plugin.cc
> @@ -211,6 +211,7 @@ static struct
>  
>    /* we disable few other plugins by default */
>    ,{ "feedback", PLUGIN_OFF }
> +  ,{ "file_key_management", PLUGIN_OFF }
>  };

Regards,
Sergei


Follow ups