maria-developers team mailing list archive

[Sergey Vojtovich <svoj@xxxxxxxxxxx>]

Hi Sergei,


On Thu, Nov 05, 2015 at 03:49:08PM +0100, Sergei Golubchik wrote:
> > > On Nov 03, Sergey Vojtovich wrote:
> > > > revision-id: 01bd3737777f8f0cf2e1737d01a48033a7615b2a (mariadb-10.1.8-23-g01bd373)
> > > > parent(s): dc40d737d4af3cb0e272c58507ad54e4eb24be28
> > > > committer: Sergey Vojtovich
> > > > timestamp: 2015-11-03 14:02:49 +0400
> > > > message:
> > > > 
> > > > MDEV-8437 - plugin variables conflict with bootstrap
> > > These patches are ok, but as far as I can see they don't fix the reported issue.
> > This particular patch fixes the problem: this is the only invocation of
> > mysqld --bootstrap that didn't ignore errors. The rest are surrounded with
> > set +e/set -e.
> 
> But 'mysqld --bootstrap' was supposed to succeed and execute statements
> that the script is feeding into it. If it fails and the error is
> suppressed I don't think it's called "fixed".
That's a fair point, but as discussed before there're two angles to view this
problem: one is that --bootstrap fails to recognize plugin options and another
one is that postinst does things which it is not supposed to do.

I'm fixing the latter. Strictly speaking upgrade should pass with just this
patch applied. But since I agree that ignoring failure of other commands is
not good, I did additional patches.

There were 5 --bootstrap invocations:
- mysql_install_db - fixed by calling on install (and not on upgrade)
- change password column - fixed by removing
- change root password - not fixed (though it's not that big problem, since it
  is mostly relevant for install and not upgrades)
- addition of debian-sys-maint - not fixed (MDEV-9081)
- create plugin table - fixed by removing

Regards,
Sergey