maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sergey!

On Nov 23, Sergey Vojtovich wrote:
> On Mon, Nov 23, 2015 at 08:39:23AM +0100, Sergei Golubchik wrote:
> > On Nov 20, Sergey Vojtovich wrote:
> > > revision-id: a1ab4314d1f88fa954a774c322709822d7b95344 (mariadb-10.1.8-58-ga1ab431)
> > > parent(s): cfc135b645db5fa78b9f63b1959ea3f2be137a26
> > > committer: Sergey Vojtovich
> > > timestamp: 2015-11-20 17:32:26 +0400
> > > message:
> > > 
> > > MDEV-7261 - Backport the default autosized value of
> > >             "table_definition_cache" from MySQL 5.6.8+
> > > 
> > > Fixed table_definition_cache auto-sizing. Note that this patch doesn't
> > > address broken PFS auto-sizing.
> > 
> > Do you plan to address it after you've broken it? How?
> PFS autosizing relies on table_definition_cache, table_open_cache,
> max_connections, open_files_limit.
> 
> The only options that is autosized prior to PFS autosizing was
> table_defintion_cache. Even this option was autosized incorrectly.
> 
> So I didn't break it, it was broken even prior to this patch. In 5.7 all these
> options are marked EARLY and are autosized before PFS autosizing.

That's what I was getting at, yes :)

Perhaps you fix should've been to move table_definition_cache to "early
options" instead of moving autosizing after normal options are
initialized. At least, that's the only fix that I see, because you
cannot auto-size P_S variables late.

Regards,
Sergei