← Back to team overview

maria-developers team mailing list archive

Re: [Commits] 8f616c7: MDEV-7780 - Support for faking server version

 

Hi, Sergey!

On Nov 26, Sergey Vojtovich wrote:
> revision-id: 8f616c777bf6756ffb9f5226a77831d3b8c98ad5 (mariadb-10.1.8-80-g8f616c7)
> parent(s): 3e69db83a792e7de8a7e7dc501a75f9f22bb6196
> committer: Sergey Vojtovich
> timestamp: 2015-11-26 14:06:21 +0400
> message:
> 
> MDEV-7780 - Support for faking server version
> 
> Added --version=str (optional argument sets server version string).
> 
> diff --git a/mysql-test/suite/sys_vars/r/version.result b/mysql-test/suite/sys_vars/r/version.result
> new file mode 100644
> index 0000000..6186e46
> --- /dev/null
> +++ b/mysql-test/suite/sys_vars/r/version.result
> @@ -0,0 +1,4 @@
> +SELECT @@version;
> +@@version
> +my_favorite_version
> +Server version:		my_favorite_version Source distribution

Sorry, I've just noticed: your test will fail in our packages, because
they have something else instead of "Source distribution".

I suspect you need to filter that out. Either with replace_result or in
perl. You can test your change by bulding with -DBUILD_CONFIG=mysql_release
or with -DCOMPILATION_COMMENT="svoj test build :)"

Ok to push after fixing it.

Regards,
Sergei