maria-developers team mailing list archive

[Robbie Harwood <rharwood@xxxxxxxxxx>]

Sergei Golubchik <serg@xxxxxxxxxxx> writes:

> Hi, Wlad!
>
> Here's a review, below.
> Just a few comments or questions.
>
> Great to have it done finally! :)
>
>> diff --git a/plugin/auth_gssapi/server_plugin.cc b/plugin/auth_gssapi/server_plugin.cc
>> new file mode 100644
>> index 0000000..64f52a3
>> --- /dev/null
>> +++ b/plugin/auth_gssapi/server_plugin.cc
>> @@ -0,0 +1,175 @@
>> +/* Copyright (c) 2015, Shuang Qiu, Robbie Hardwood,
>> +   Vladislav Vaintroub & MariaDB Corporation
>> +
>> +   All rights reserved.
>> +
>> +   Redistribution and use in source and binary forms, with or without
>> +   modification, are permitted provided that the following conditions are met:
>> +
>> +   1. Redistributions of source code must retain the above copyright notice,
>> +      this list of conditions and the following disclaimer.
>> +
>> +   2. Redistributions in binary form must reproduce the above copyright notice,
>> +      this list of conditions and the following disclaimer in the documentation
>> +      and/or other materials provided with the distribution.
>> +
>> +   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
>> +   AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>> +   IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
>> +   ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
>> +   LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
>> +   CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
>> +   SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
>> +   INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
>> +   CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>> +   ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
>> +   POSSIBILITY OF SUCH DAMAGE.
>
> 2-clause BSD. Was it Robbie who asked for it?

I released my work under BSD.  I am not a lawyer, but I believe this
means it can be taken as GPL if desired.  (I'm okay with this, but have
not signed the CLA.)

Also, re-reading this, can we fix the spelling of my name?  "Harwood",
please.  Thanks!

--Robbie

Attachment: signature.asc
Description: PGP signature