← Back to team overview

maria-developers team mailing list archive

Re: [Commits] cae1945: MDEV-9117: Client Server capability negotiation for MariaDB specific functionality

 

Hi, Oleksandr!

On Jan 17, Oleksandr Byelkin wrote:

> >>>>>> +      if (ext_client_capabilities & MARIADB_CLIENT_EXTENDED_FLAGS)
> >>>>>> +        client_capabilities|= ext_client_capabilities;
> >>>>>> +      else
> >>>>>> +      {
> >>>>>> +        DBUG_PRINT("error", ("CLIENT_PROTOCOL_41: on, "
> >>>>>> +                             "CLIENT_LONG_PASSWORD/CLIENT_MYSQL off, "
> >>>>>> +                             "but MARIADB_CLIENT_EXTENDED_FLAGS is off. "
> >>>>>> +                             "flags: %llx ext flags %llx",
> >>>>>> +                             client_capabilities, ext_client_capabilities));
> >>>>>> +        return packet_error;
> >>>>> Why do you need that (MARIADB_CLIENT_EXTENDED_FLAGS and the check)?

> I meant flag CLIENT_MYSQL. But there is other function, report extended 
> functionality to client  (clein also can understand that it is mariaDB 
> server, but the flag alwais set in extended flag area is additional check.

I don't understand. What additional safety does this additional check
give you?

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx
-- 
Vote for my Percona Live 2016 talks:
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-connectors-fast-and-smart-new-protocol-optimizations#community-voting
https://www.percona.com/live/data-performance-conference-2016/sessions/mariadb-101-security-validation-authentication-encryption#community-voting


Follow ups

References