maria-developers team mailing list archive

[Alexander Barkov <bar@xxxxxxxxxxx>]

Hi Sergei,


On 02/18/2016 06:45 PM, Sergei Golubchik wrote:
> Hi, Alexander!
>
> On Feb 18, Alexander Barkov wrote:
> > Hi Sergei,
> >
> > Please review a patch for MDEV-7231.
>
> Sorry, I cannot understand what parts of this patch are fixing MDEV-7231
> and what is fixing charset issue.
>
> Could you please split this patch in two - one for MDEV-7231 and the
> other for charsets?

Hmm. I'm not fixing any charset issues.
Which parts do you think are not related?

The problem was that the ROUTINE_DEFINITION:

- Did not escape special characters and quotes in text and binary 
literals. Now it does.

- Also, in now converts some binary strings to X'hhhh' notation,
  when conversion to utf8 would produce confusingly looking
  constants. It's another side of the same problem.

> Regards,
> Sergei
> Chief Architect MariaDB
> and security@xxxxxxxxxxx