maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexander!

On Apr 04, Alexander Barkov wrote:
> Hi Sergei,
> 
> Please review a patch for MDEV-9823.
> 
> This is a prerequisite for the current sprint task:
> MDEV-6353 my_ismbchar() and my_mbcharlen() refactoring

1. I cannot review eucjpms and ujis changes, I'll believe they're ok :)

2. I can barely understand what you've changed in sql_load.cc, I've
   already asked you not to combine cleanups and bugfixes in one commit.

   Split it in two, please, then I'll review them.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx