maria-developers team mailing list archive

Thread
Date

Re: fa129a7: MDEV-9728 - Hard crash in metadata_lock_info

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Mon, 20 Jun 2016 10:58:10 +0200
In-reply-to: <20160617085520.BE60D2C8C3F@mail.askmonty.org>
User-agent: Mutt/1.5.24 (2015-08-30)

Hi, Sergey!

Looks ok to push, thanks!

On Jun 17, Sergey Vojtovich wrote:
> revision-id: fa129a7d22656eff9a7d1fb137d22976e0f0cec1 (mariadb-10.0.25-7-gfa129a7)
> parent(s): 56ec3bdebd4a17ff59a487a988069f77bfc69aab
> committer: Sergey Vojtovich
> timestamp: 2016-06-17 12:52:35 +0400
> message:
> 
> MDEV-9728 - Hard crash in metadata_lock_info
> 
> metadata_lock_info plugin called MDL_context::find_ticket() to obtain lock
> duration, which in turn iterates foreign thread private lists. These lists
> can be updated by owner thread without protection.
> 
> Fixed by iterating threads (instead of MDL locks and tickets) and obtaining
> data through APC.
> 
> Also fixed mdl_iterate_lock() to initialize iterator under prlock protection.
> 
Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx