maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexander!

On Jun 22, Alexander Barkov wrote:
> Hi Serg.
> 
> Please review a patch for MDEV-10236.
> 
> Thanks.

> commit bb3afc8aea61bc090a1119be0a1dad32d9dc8feb
> Author: Alexander Barkov <bar@xxxxxxxxxxx>
> Date:   Wed Jun 22 16:30:15 2016 +0400
> 
>     MDEV-10236 Where expression with NOT function gives incorrect result

Could you be more verbose in the comment please?
I don't understand what was causing the bug or what you have fixed.

> diff --git a/sql/item.h b/sql/item.h
> index bef57c4..93da398 100644
> --- a/sql/item.h
> +++ b/sql/item.h
> @@ -5050,7 +5050,7 @@ class Item_cache: public Item_basic_constant
>    bool basic_const_item() const
>    { return MY_TEST(example && example->basic_const_item()); }
>    virtual void clear() { null_value= TRUE; value_cached= FALSE; }
> -  bool is_null() { return null_value; }
> +  bool is_null() { return !has_value(); }
>    virtual bool is_expensive()
>    {
>      if (value_cached)

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx