maria-developers team mailing list archive
Mailing list archive
Re: [Commits] 3bbf3d2: MDEV-10216: Assertion `strcmp(share->unique_file_name, filename) ||
Can you please 2nd review this patch?
On Tue, Jul 5, 2016 at 4:51 AM, Sergey Vojtovich <svoj@xxxxxxxxxxx> wrote:
> Hi Nirbhay,
> Looks good, thanks!
> On Fri, Jul 01, 2016 at 02:47:29PM -0400, Nirbhay Choubey wrote:
> > revision-id: 3bbf3d2e246da1a2fd458b634f30cbe35afb5668
> > parent(s): 76f492e26d8d45c678c570be2cf4ca5d238edceb
> > author: Nirbhay Choubey
> > committer: Nirbhay Choubey
> > timestamp: 2016-07-01 14:47:27 -0400
> > message:
> > MDEV-10216: Assertion `strcmp(share->unique_file_name,filename) ||
> > .. share->last_version' failed in myisam/mi_open.c:67: test_if_reopen
> > During the RENAME operation since the renamed temporary table is also
> > opened and added to myisam_open_list/maria_open_list, resetting the
> > last_version at the end of operation (HA_EXTRA_PREPARE_FOR_RENAME)
> > will cause an assertion failure when a subsequent query tries to open
> > an additional temporary table instance and thus attempts to reuse it
> > from the open table list.
> > This commit fixes the issue by skipping flush/close operations executed
> > toward the end of ALTER for temporary tables. It also enables a shortcut
> > for simple ALTERs (like rename, disable/enable keys) on temporary
> > tables.
> > As safety checks, added some assertions at code points that should not
> > be hit for temporary tables.
> commits mailing list