maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sergey!

So, what did you do here? Did you change InnoDB's version of crc32 or
just moved it to extra/ ?

You removed mysys/my_crc32.c - where will crc32 come from on x86?

Why did you name new function crc32_vpmsum instead of just naming it
crc32 and avoding #ifdef's elsewhere?

On Jul 05, Sergey Vojtovich wrote:
> revision-id: e252dae86392a2b50d647a380db36fb8b01bf405 (mariadb-10.2.1-5-ge252dae)
> parent(s): 72c94872835f27b536f617978dbc664ddb57da06
> committer: Sergey Vojtovich
> timestamp: 2016-07-05 18:09:23 +0400
> message:
> 
> MDEV-9872 - Add common optimized CRC32 function interface
> 
> Move crc32-vpmsum to extra.
> Compile static crc32-vpmsum instead of adding sources directly.
> Make use of crc32-vpmsum via my_checksum().
> 
> Based on contribution by Daniel Black.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx