← Back to team overview

maria-developers team mailing list archive

Re: [Commits] 66b4459: MDEV-9143 JSON_xxx functions.


Hi, Alexey!

On Sep 05, Alexey Botchkov wrote:
> revision-id: 66b4459e38f5df4913ecce1c9e3d71c7afa7860d (mariadb-10.2.1-21-g66b4459)
> parent(s): 31a8cf54c8a7913338480a0571feaf32143b5f64
> committer: Alexey Botchkov
> timestamp: 2016-09-05 14:03:33 +0400
> message:
> MDEV-9143 JSON_xxx functions.
> Library with JSON-related functions added.

I've just briefly looked through the code, assuming it's mostly the same
as the in previous commit. Looks much better comment- and naming-wise,

Could please you add some unit tests for it into unittest/strings ?
In a separate commit, if you'd like, that doesn't matter.

Chief Architect MariaDB
and security@xxxxxxxxxxx