maria-developers team mailing list archive

Thread
Date

Re: [Commits] 66b4459: MDEV-9143 JSON_xxx functions.

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 9 Sep 2016 08:30:54 +0200
Cc: holyfoot@xxxxxxxxxxx
In-reply-to: <20160905100509.96724140DDB@nebo.localdomain>
User-agent: Mutt/1.5.24 (2015-08-30)

Hi, Alexey!

On Sep 05, Alexey Botchkov wrote:
> revision-id: 66b4459e38f5df4913ecce1c9e3d71c7afa7860d (mariadb-10.2.1-21-g66b4459)
> parent(s): 31a8cf54c8a7913338480a0571feaf32143b5f64
> committer: Alexey Botchkov
> timestamp: 2016-09-05 14:03:33 +0400
> message:
> 
> MDEV-9143 JSON_xxx functions.
> 
> Library with JSON-related functions added.

I've just briefly looked through the code, assuming it's mostly the same
as the in previous commit. Looks much better comment- and naming-wise,
thanks.

Could please you add some unit tests for it into unittest/strings ?
In a separate commit, if you'd like, that doesn't matter.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx