maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexander!

On Sep 21, Alexander Barkov wrote:
> commit 6c49030635a36380606948c198dcfd4a6bf2ffc3
> Author: Alexander Barkov <bar@xxxxxxxxxxx>
> Date:   Wed Sep 21 12:29:09 2016 +0400
> 
>     MDEV-10425 Assertion `collation.derivation == DERIVATION_IMPLICIT' failed in Item_func_conv_charset::fix_length_and_dec()
>     MDEV-10850 Wrong result for WHERE .. (f2=TO_BASE64('test') OR f2=TO_BASE64('TEST'))
...
>     Solution:
>     - Removing the code changing args[0]->collation
>     - Introducing Item_str_ascii_checksum_func as a common parent
>       for Item_func_{md5|sha|sha2|password|hex|to_base64}
>       and overriding its eq() method to compare arguments binary.

Good fix, thanks!
Ok to push

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx