maria-developers team mailing list archive

Thread
Date

Possibly a problem in "Allowed to use WITH clauses before SELECT in CREATE ... SELECT and INSERT ... SELECT"

To: Igor Babaev <igor@xxxxxxxxxxxx>, maria-developers <maria-developers@xxxxxxxxxxxxxxxxxxx>
From: Alexander Barkov <bar@xxxxxxxxxxx>
Date: Wed, 28 Sep 2016 07:25:14 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

Hello Igor,

I was rebasing bb-10.2-compatibility on top of the latest 10.2 andnoticed this grammar change:

 create_select_query_specification:
-          SELECT_SYM create_select_part2 create_select_part3 create_select_part4
+          SELECT_SYM opt_with_clause create_select_part2 create_select_part3
+          create_select_part4
+          {
+            Select->set_with_clause($2);
+          }
         ;



I have some questions:

- From my understanding, opt_with_clause should go before SELECT_SYM
  Why does it go after?

- Why this grammar change is not covered in tests?

- What is the MDEV number for this change?


Thanks!