← Back to team overview

maria-developers team mailing list archive

Re: MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition


Hi Sanja,

On 11/20/2016 12:29 AM, Oleksandr Byelkin wrote:

Patch is OK to push.

Thanks for reviewing!

Actually it is good sign that 'refefence->field'
turned to 'field' now!

Yeah, this makes the code easier to read.


On Fri, Nov 18, 2016 at 12:43 PM, Alexander Barkov <bar@xxxxxxxxxxx
<mailto:bar@xxxxxxxxxxx>> wrote:

    Hello Sanja,

    can you please review a patch for MDEV-11245 for 10.3?

    It's a small refactoring intended to make patches for these tasks
    look better:

    - MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations
    - MDEV-10914 ROW data type for stored routine variables