maria-developers team mailing list archive

Thread
Date

Re: MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition

To: Oleksandr Byelkin <sanja@xxxxxxxxxxx>
From: Alexander Barkov <bar@xxxxxxxxxxx>
Date: Sun, 20 Nov 2016 08:03:28 +0400
Cc: maria-developers <maria-developers@xxxxxxxxxxxxxxxxxxx>
In-reply-to: <CADYFmDSNLOX_RMAf=jBg2nEA7DejvjokYBkUVcBRwcxUkb3BJQ@mail.gmail.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0

Hi Sanja,


On 11/20/2016 12:29 AM, Oleksandr Byelkin wrote:

Hi!

Patch is OK to push.


Thanks for reviewing!

Actually it is good sign that 'refefence->field'
turned to 'field' now!


Yeah, this makes the code easier to read.

Greetings!


On Fri, Nov 18, 2016 at 12:43 PM, Alexander Barkov <bar@xxxxxxxxxxx
<mailto:bar@xxxxxxxxxxx>> wrote:

    Hello Sanja,

    can you please review a patch for MDEV-11245 for 10.3?

    It's a small refactoring intended to make patches for these tasks
    look better:

    - MDEV-10577 sql_mode=ORACLE: %TYPE in variable declarations
    - MDEV-10914 ROW data type for stored routine variables

    Thanks!

References

MDEV-11245 Move prepare_create_field and sp_prepare_create_field() as methods to Column_definition
From: Alexander Barkov, 2016-11-18