← Back to team overview

maria-developers team mailing list archive

Re: MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler

 

Hi Bar,

On Tue, Nov 22, 2016 at 12:33 PM, Alexander Barkov <bar@xxxxxxxxxxx> wrote:

> Hello Nirbhay,
>
> Can you please review a patch for 10.3:


> MDEV-11337 Split Item::save_in_field() into virtual methods in Type_handler
>
>
> It also automatically fixed two problems:
>
> MDEV-11331 Wrong result for INSERT INTO t1 (datetime_field) VALUES
> (hybrid_function_of_TIME_data_type)
> MDEV-11333 Expect "Impossible where condition" for WHERE
> timestamp_field>=DATE_ADD(TIMESTAMP'9999-01-01 00:00:00',INTERVAL 1000
> YEAR)
>
> because the new code is now symmetric for all data types.
>

Looks good. Ok to push.

Best,
Nirbhay


>
> Thanks!
>

Follow ups

References