← Back to team overview

maria-developers team mailing list archive

Re: [Commits] bbc52df: MDEV-11490 Galera_3nodes test suite does not suppress Warnings.

 

Hi Sachin,

I see that you have added a lot of warnings to the suite-level suppression
list.
Does *all* the new warnings show up for all the tests?

I'd only add ones that make sense for the entire suite, and add the
individuals
to the specific test by calling mtr.add_suppression("<pattern>").

Ping me on slack if you need to discuss this further.

Best,
Nirbhay

On Tue, Dec 6, 2016 at 1:53 AM, <sachin.setiya@xxxxxxxxxxx> wrote:

> revision-id: bbc52df39b7dedca50943a7cd99ee80b9e2f5b12
> (mariadb-10.1.19-24-gbbc52df)
> parent(s): 611f91605adce17df87acf96b5aede0b73d0fc12
> author: SachinSetiya
> committer: SachinSetiya
> timestamp: 2016-12-06 12:21:16 +0530
> message:
>
> MDEV-11490 Galera_3nodes test suite does not suppress Warnings.
>
> Problem:- While running individual tests of Galera_3nodes ,
> We get warnings like '[Warning] WSREP: Could not open state file
>  for reading: '. And because of this individual tests fails.
>
> Solution:- We change suite.pm of Galera_3nodes to supress these warnings.
>
> ---
>  mysql-test/suite/galera_3nodes/suite.pm | 34
> ++++++++++++++++++++++++++++-----
>  1 file changed, 29 insertions(+), 5 deletions(-)
>
> diff --git a/mysql-test/suite/galera_3nodes/suite.pm
> b/mysql-test/suite/galera_3nodes/suite.pm
> index 39d5acb..74f7dfa 100644
> --- a/mysql-test/suite/galera_3nodes/suite.pm
> +++ b/mysql-test/suite/galera_3nodes/suite.pm
> @@ -25,7 +25,8 @@ return "No my_print_defaults" unless $epath;
>  push @::global_suppressions,
>    (
>       qr(WSREP: wsrep_sst_receive_address is set to '127.0.0.1),
> -     qr(WSREP: Could not open saved state file for reading: ),
> +     qr(WSREP: Could not open saved state file for reading: .*),
> +     qr(WSREP: Could not open state file for reading: .*),
>       qr(WSREP: Gap in state sequence. Need state transfer.),
>       qr(WSREP: Failed to prepare for incremental state transfer:),
>       qr(WSREP:.*down context.*),
> @@ -33,16 +34,39 @@ push @::global_suppressions,
>       qr(WSREP: last inactive check more than .* skipping check),
>       qr(WSREP: SQL statement was ineffective),
>       qr(WSREP: Releasing seqno [0-9]* before [0-9]* was assigned.),
> -     qr|WSREP: access file\(gvwstate.dat\) failed\(No such file or
> directory\)|,
> +     qr|WSREP: access file\(.*gvwstate.dat\) failed\(No such file or
> directory\)|,
>       qr(WSREP: Quorum: No node with complete state),
>       qr(WSREP: Initial position was provided by configuration or SST,
> avoiding override),
>       qr|WSREP: discarding established \(time wait\) .*|,
>       qr(WSREP: There are no nodes in the same segment that will ever be
> able to become donors, yet there is a suitable donor outside. Will use that
> one.),
>       qr(WSREP: evs::proto.*),
> -     qr|WSREP: Ignoring possible split-brain (allowed by configuration)
> from view:.*|,
> +     qr|WSREP: Ignoring possible split-brain \(allowed by configuration\)
> from view:.*|,
> +     qr(WSREP: no nodes coming from prim view, prim not possible),
> +     qr(WSREP: Member .* requested state transfer from .* but it is
> impossible to select State Transfer donor: Resource temporarily
> unavailable),
> +     qr(WSREP: user message in state LEAVING),
> +     qr(WSREP: .* sending install message failed: Transport endpoint is
> not connected),
> +     qr(WSREP: .* sending install message failed: Resource temporarily
> unavailable),
> +     qr(WSREP: Maximum writeset size exceeded by .*),
> +     qr(WSREP: transaction size exceeded.*),
> +     qr(WSREP: RBR event .*),
> +     qr(WSREP: Ignoring error for TO isolated action: .*),
> +     qr(WSREP: transaction size limit .*),
> +     qr(WSREP: rbr write fail, .*),
> +     qr(WSREP: .*Backend not supported: foo.*),
> +     qr(WSREP: .*Failed to initialize backend using .*),
> +     qr(WSREP: .*Failed to open channel 'my_wsrep_cluster' at .*),
> +     qr(WSREP: gcs connect failed: Socket type not supported),
> +     qr(WSREP: failed to open gcomm backend connection: 110: failed to
> reach primary view: 110 .*),
> +     qr(WSREP: .*Failed to open backend connection: -110 .*),
> +     qr(WSREP: .*Failed to open channel 'my_wsrep_cluster' at .*),
> +     qr(WSREP: gcs connect failed: Connection timed out),
> +     qr|WSREP: wsrep::connect\(.*\) failed: 7|,
> +     qr(WSREP: SYNC message from member .* in non-primary configuration.
> Ignored.),
>       qr(WSREP: Could not find peer:),
> -     qr(WSREP: Protocol violation. JOIN message sender .*),
> -     qr(WSREP: JOIN message from member [0-9]* in non-primary
> configuration. Ignored.),
> +     qr(WSREP: TO isolation failed for: .*),
> +     qr|WSREP: gcs_caused\(\) returned .*|,
> +     qr|WSREP: Protocol violation. JOIN message sender .* is not in state
> transfer \(SYNCED\). Message ignored.|,
> +     qr(WSREP: Action message in non-primary configuration from member
> [0-9]*),
>     );
>
>
> _______________________________________________
> commits mailing list
> commits@xxxxxxxxxxx
> https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits

Follow ups