← Back to team overview

maria-developers team mailing list archive

Re: [Commits] [PATCH] Use size_t in thd_alloc() and friends.


Hi Sergei,

On Sat, Mar 11, 2017 at 9:09 PM, Sergei Golubchik <serg@xxxxxxxxxxx> wrote:

> Marko, when you change the ABI of services you absolutely must update
> coresponding service versions in include/service_versions.h.
> May be, it's best not to break the ABI for such a minor reason and only
> change THD methods, not service functions.

Based on your feedback, I will not push this patch. Instead, I pushed a few
other size_t patches to bb-10.2-marko for testing. With those patches, the
warning count on 64-bit Windows (where size_t is 64 bits but long is 32
bits) will be a little lower than it is now. The warning count on 32-bit
Windows is approaching a bearable number.

Best regards,

April 11 - 12, 2017
The Conrad Hotel
New York City

Marko Mäkelä, Lead Developer InnoDB
MariaDB Corporation