← Back to team overview

maria-developers team mailing list archive

Re: 9f33288dde9: MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS

 

Hi, Jacob!

On Mar 16, jacob.mathew@xxxxxxxxxxx wrote:
> revision-id: 9f33288dde950343c46e6c5d6a4f233de191f477 (mariadb-10.2.3-245-g9f33288dde9)
> parent(s): 7c152ac68a7993bca99ef23e073b0a0974b087a1
> author: Jacob Mathew
> committer: Jacob Mathew
> timestamp: 2017-03-16 14:41:41 -0700
> message:
> 
> MDEV-11115 CHECK constraints are not shown in I_S.TABLE_CONSTRAINTS
> 
> Add test case: check_constraint_show
> 
> diff --git a/mysql-test/t/check_constraint_show.test b/mysql-test/t/check_constraint_show.test
> new file mode 100644
> index 00000000000..0e2f45883df
> --- /dev/null
> +++ b/mysql-test/t/check_constraint_show.test
> @@ -0,0 +1,8 @@
> +# Table with 2 column-level check constraints and 1 table-level check constraint
> +create or replace table t1( c1 int, c2 int, c3 int, primary key( c1
> ), constraint `c1_min` check( c1 > 0 ), constraint `c3_min` check( c3
> > 0 ), constraint `range`  check( ( c2 >= c1 ) and ( c2 <= c3 ) ) );
> +show create table t1;
> +
> +# Show all constraints, including check constraints
> +select * from information_schema.table_constraints where table_name = 't1';
> +
> +drop table t1;

This is good, thanks!
But please, test column-level constraints too, as I've asked in a review.
Something like

  create table t1 (c1 int check(c1 > 10), c2 int check (c2 < c1), ...)

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx