← Back to team overview

maria-developers team mailing list archive

Please review a patch for Mdev-12019

 

Hi Monty,

Please review a patch for Mdev-12019.

-- 
Regards
Sachin Setiya
Software Engineer at  MariaDB
commit 62cda14d7d34fb4a27bad99e7d5aea1c52a71023
Author: Sachin Setiya <sachinsetia1001@xxxxxxxxx>
Date:   Mon Apr 3 11:55:51 2017 +0530

    MDEV-12019 FLASHBACK: Server crashes in bitmap_bits_set / pack_row / ...
    
    Reason for this crash is that table->rpl_write_set is NULL. In
    Rows_log_event::do_apply_event we set table->rpl_write_set equal to
    table->write_set. But we do not set table->rpl_write_set in
    Old_rows_log_event::do_apply_event.

diff --git a/sql/log_event_old.cc b/sql/log_event_old.cc
index 552221e..a2a5211 100644
--- a/sql/log_event_old.cc
+++ b/sql/log_event_old.cc
@@ -221,6 +221,8 @@ Old_rows_log_event::do_apply_event(Old_rows_log_event *ev, rpl_group_info *rgi)
     /* A small test to verify that objects have consistent types */
     DBUG_ASSERT(sizeof(ev_thd->variables.option_bits) == sizeof(OPTION_RELAXED_UNIQUE_CHECKS));
 
+    table->rpl_write_set= table->write_set;
+
     error= do_before_row_operations(table);
     while (error == 0 && row_start < ev->m_rows_end)
     {