← Back to team overview

maria-developers team mailing list archive

Re: Please review a patch removing LEX::text_string_is_7bit


Hi, Alexander!

On Mar 30, Alexander Barkov wrote:
> Hello Sergei,
> Can you please review a patch for bb-10.2-ext fixing the problem
> that in case of possible changes in look-ahead in rules using
> TEXT_STRING or NCHAR_STRING, Lex->text_string_is_7bit can get out of
> sync with $1/$2/$3, etc.

No comments on the approach, looks ok.

Few details:

 * Lex_string_with_metadata_st is very vague. Lex_string_with_repertoire
   would be better (e.g. there's CSET_STRING which is LEX_STRING +
   CHARSET_INFO, it's also "LEX_STRING with metadata" in a sense).
 * It's only used in the lexer/parser, so putting it in sql_lex.h would
   be more appropriate. The rest of the server will hardly need to use
   Lex_string_with_repertoire, it's too lexer/parser specific.

Chief Architect MariaDB
and security@xxxxxxxxxxx

Follow ups