maria-developers team mailing list archive

[Alexander Barkov <bar@xxxxxxxxxxx>]

Hi,

Monty, Marko, Vicentiu, thanks for your replies.

I collected all input to:
https://jira.mariadb.org/browse/TODO-916
Please have a look.

Input from other developers would be very welcome! Thanks.



On 04/20/2017 09:57 AM, Alexander Barkov wrote:
<cut>
>>
>>     I'd propose two things instead:
>>
>>     1. Add a class:
>>
>>
>> No reason to make a complex solution for a problem that doesn't exist. 
> 
> 
> It's a trivial solution.
> 
> The problem does exists. The current code absolutely is excessive
> and inconvenient to use.

We can go without a class actually. As Marko mentioned,
there is another safer option, to have conversion functions.
See an example to_lex_cstring() in
https://jira.mariadb.org/browse/TODO-916

So there is no a need for "class Lex_cstring".
Using just "const LEX_CSTING &name" to pass names should be very good.

<cut>