maria-developers team mailing list archive
Mailing list archive
Re: MDEV-12506 Split Item_func_min_max::fix_length_and_dec() into methods in Type_handler
Thanks for your review!
On 04/22/2017 06:49 PM, Alexey Botchkov wrote:
> Ok to push.
> I'd only move the bool Item_func_min_max::fix_attributes(Item **items,
> uint nitems) function
> to the item_func.h as it's just the typehandler method call now.
I'm afraid this is not possible.
This method uses current_thd->is_error(), and the structure of THD
is not visible in item_func.h.
> Best regards.
> On Sat, Apr 15, 2017 at 7:23 AM, Alexander Barkov <bar@xxxxxxxxxxx
> <mailto:bar@xxxxxxxxxxx>> wrote:
> Hello Alexey,
> Can you please review a patch for MDEV-12506?