← Back to team overview

maria-developers team mailing list archive

Re: Obsolete GTID domain delete on master (MDEV-12012, MDEV-11969)

 

Kristian, hello.

Now to the implementation matter,

> The procedure to fix it will then be:
>
> 1. FLUSH BINARY LOGS, note the new GTID position.
>
> 2. Ensure that all slaves are past the problematic point with
> MASTER_GTID_WAIT(<pos>). After this, the old errorneous binlog files
> are no
> longer needed.
>
> 3. PURGE BINARY LOGS to remove the errorneous logs.
>
> 4. FLUSH BINARY LOG DELETE DOMAIN d
>

I think we could optimize the list. How about

1. Take note of @@global.gtid_binlog_state
2. Ensure that all slaves are past the last event of being deleted domain 'd'
3. PURGE BINARY LOGS DELETE DELETE 'd'

  The effect of the last step would include purging all the binary log
  files plus a planned implicit FLUSH LOGS discarding 'd' from the new
  emerged binlog.

It's one command less and besides PURGE as the command name reflects
better the action. Perhaps you shared that feeling when spoke 'PURGE'
in your initial response to 12012.

Please tell me how this looks from your perspective.

Thanks!

Andrei





Follow ups

References