maria-developers team mailing list archive

Thread
Date

Re: [Commits] 3f7e619647f: MDEV-13928: Missing symbols building RocksDB on macOS 10.12.6

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Thu, 5 Oct 2017 21:23:32 +0200
Cc: varun@xxxxxxxxxxx
In-reply-to: <20171005185029.28D4EA20346@Varuns-MacBook-Pro.local>
User-agent: Mutt/1.7.2 (2016-11-26)

Hi, Varun!

Why did it fail only on MacOS X?

On Oct 06, Varun wrote:
> revision-id: 3f7e619647f7bc1ec31a6118b403da805c48ae51 (mariadb-10.2.5-653-g3f7e619647f)
> parent(s): 08c493c62afae0e81f9da6bb9b86efe99a9a763d
> author: Varun Gupta
> committer: Varun Gupta
> timestamp: 2017-10-06 00:20:08 +0530
> message:
> 
> MDEV-13928: Missing symbols building RocksDB on macOS 10.12.6
> 
> rdb_sst_info.cc must be compiled with RTTI
> 
> ---
>  storage/rocksdb/CMakeLists.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/storage/rocksdb/CMakeLists.txt b/storage/rocksdb/CMakeLists.txt
> index 6db82119b45..80a6614b757 100644
> --- a/storage/rocksdb/CMakeLists.txt
> +++ b/storage/rocksdb/CMakeLists.txt
> @@ -170,6 +170,7 @@ IF(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
>    #  includes requires it. So, now everything in MariaRocks is compiled with
>    #  -frtti)
>    set_source_files_properties(event_listener.cc rdb_cf_options.cc
> +  rdb_sst_info.cc
>      PROPERTIES COMPILE_FLAGS -frtti)
>  ENDIF()

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx