maria-developers team mailing list archive

[Marko Mäkelä <marko.makela@xxxxxxxxxxx>]

This file should not have been re-added in the first place.
I removed this badly working file for a good reason.

Please try to read the git history before re-adding broken tests.

We now have many useless and outright broken tests in
--suite=innodb_gis that need some cleanup.
I would have liked to review the test changes. Good tests are as
valuable as good code.

commit 86e0a73eaa166f752d62b31e96925e29c4fe0c8c
Author: Marko Mäkelä <marko.makela@xxxxxxxxxxx>
Date:   Mon Aug 7 23:38:27 2017 +0300

    Remove wait_innodb_all_purged.inc

    The file wait_innodb_all_purged.inc waited for InnoDB purge in a way
    that only worked in debug builds. The file wait_all_purged.inc
    provides a better mechanism.

The wait_all_purged.inc was added almost 6 months ago:

file commit 0bfa3dff8b95ed8b8bd133e434b47189857121ac
Author: Marko Mäkelä <marko.makela@xxxxxxxxxxx>
Date:   Tue May 16 12:07:26 2017 +0300

    MDEV-12698 innodb.innodb_stats_del_mark test failure

On Tue, Oct 24, 2017 at 12:24 PM, jan <jan.lindstrom@xxxxxxxxxxx> wrote:
> revision-id: 58c9df453f5d8408dd189fb2e5ae4445446b6701 (mariadb-10.2.9-80-g58c9df453f5)
> parent(s): 39f86dd27a4c772f0b0a65fbf9b125be9e2dc8ac
> author: Jan Lindström
> committer: Jan Lindström
> timestamp: 2017-10-24 12:23:57 +0300
> message:
>
> Remove usage of unknown parameter.
>
> ---
>  mysql-test/include/wait_innodb_all_purged.inc | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/mysql-test/include/wait_innodb_all_purged.inc b/mysql-test/include/wait_innodb_all_purged.inc
> index 5bf816fd72f..c5edc5937da 100644
> --- a/mysql-test/include/wait_innodb_all_purged.inc
> +++ b/mysql-test/include/wait_innodb_all_purged.inc
> @@ -48,7 +48,6 @@ WHERE VARIABLE_NAME = 'INNODB_PURGE_TRX_ID_AGE';`;
>      }
>      if (!$success)
>      {
> -        set global innodb_purge_run_now=ON;
>          real_sleep 0.1;
>          dec $wait_counter;
>      }
> _______________________________________________
> commits mailing list
> commits@xxxxxxxxxxx
> https://lists.askmonty.org/cgi-bin/mailman/listinfo/commits



-- 
Marko Mäkelä, Lead Developer InnoDB
MariaDB Corporation