maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexey!

On Dec 12, Alexey Botchkov wrote:
> revision-id: 14acb687199f0d30444f8c0849c0d1c1284f3e2b (mariadb-10.2.11-26-g14acb68)
> parent(s): 4d016e6ed2d32298977a66e125cbfcae39e23847
> committer: Alexey Botchkov
> timestamp: 2017-12-12 14:31:41 +0400
> message:
> 
> MDEV-14593 human-readable XA RECOVER.
> 
> The 'data' field in the XA RECOVER resultset changed
> to be charset_bin. It seems to me right and also
> --binary-as-hex starts working.
> The XA RECOVER FORMAT='SQL' option implemented.
> It returns the XID string that fits to be an argument for the
> XA ... statements.

Looks ok, just a couple of comments:

> +xa recover format='SQL';

Please add a test for format=SQL (without quotes).

We normally document EXPLAIN FORMAT=JSON without quotes
(although it works with quotes too), so XA RECOVER should work the same
way.

> +ER_UNKNOWN_XID_FORMAT
> +  eng "Unknown XID format name: '%s'"

Don't add a new error message, reuse ER_UNKNOWN_EXPLAIN_FORMAT:

-  eng "Unknown EXPLAIN format name: '%s'"
-  rus "Неизвестное имя формата команды EXPLAIN: '%s'"
+  eng "Unknown %s format name: '%s'"
+  rus "Неизвестное имя формата команды %s: '%s'"

note, you'll need either to remove/rephrase the russian error message,
or use "XA RECOVER" as the first argument, not "XID".

Ok to push (into bb-10.2-ext) with these changes.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx