maria-developers team mailing list archive

Thread
Date

Re: [Commits] 203a658: MDEV-11084 Select statement with partition selection against MyISAM table opens all partitions.

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Tue, 19 Dec 2017 21:14:12 +0100
Cc: holyfoot@xxxxxxxxxxx
In-reply-to: <20171218153309.63BEE140C77@nebo.localdomain>
User-agent: Mutt/1.7.2 (2016-11-26)

Hi, Alexey!

On Dec 18, Alexey Botchkov wrote:
> revision-id: 203a6585d3deedb36e30d5ebf388de44b6810403 (mariadb-10.1.23-51-g203a658)
> parent(s): e4d10e09cf318aad237143254c45458d16009f70
> committer: Alexey Botchkov
> timestamp: 2017-12-18 19:31:26 +0400
> message:
> 
> MDEV-11084 Select statement with partition selection against MyISAM table opens all partitions.
> 
>         Now SELECT FROM t PARTITION(x) only opens the 'x' file.
>         The table->partition_names parameter is sent to ha_open
>         so it only opens the required partitions.
>         If the table is reopened, the
>         change_partition_to_open(partition_names) is called that
>         closes and opens partitions specified for the query.

Looks ok to me, thanks!

Please add some tests, can status variables show the difference in the
number of opened partitions?

And make sure that the whole tree compiles without partitioning.

Then ok to push into 10.3

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx