maria-developers team mailing list archive

Thread
Date

Re: a01f9ff: MDEV-11071 - Assertion `thd->transaction.stmt.is_empty()' failed in

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Wed, 27 Dec 2017 12:32:57 +0100
In-reply-to: <20171226105052.132C685000E@mail.askmonty.org>
User-agent: Mutt/1.7.2 (2016-11-26)

Hi, Sergey!

On Dec 26, Sergey Vojtovich wrote:
> revision-id: a01f9ff80b892bf32dd2754da17438e8884c003a (mariadb-10.2.11-51-ga01f9ff)
> parent(s): c3bd0b0301936d0dcd0918bb8c966c272610d61b
> committer: Sergey Vojtovich
> timestamp: 2017-12-26 14:38:45 +0400
> message:
> 
> MDEV-11071 - Assertion `thd->transaction.stmt.is_empty()' failed in
>              Locked_tables_list::unlock_locked_tables
> 
> Similarly to regular DROP TABLE, don't leave locked tables mode if CREATE OR
> REPLACE dropped temporary table but failed to cerate new one.
> 
> The problem is that there's no track of which temporary table was "locked" by
> LOCK TABLES.

Looks reasonable.
Could you also add a test where t2 is locked and t2 is dropped?
Just to show that pos_in_locked_tables works for temporary tables.

Ok to push after that.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx