← Back to team overview

maria-developers team mailing list archive

Dead code Type_handler_hybrid_field_type::m_vers_trx_id ?


  Hi Aleksey,

You added Type_handler_hybrid_field_type::m_vers_trx_id.

Is it really needed? It seems to be always "false".
So this code in aggregate_for_comparison() seems to be a dead code:

  if (m_vers_trx_id && (a == STRING_RESULT || b == STRING_RESULT))
    m_type_handler= &type_handler_datetime;

Can I remove m_vers_trx_id and this dead code?


Follow ups