maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Sergey!

On Apr 12, Sergey Petrunia wrote:
> > diff --git a/sql/item_strfunc.h b/sql/item_strfunc.h
> > index 18cda491efd..49de5568696 100644
> > --- a/sql/item_strfunc.h
> > +++ b/sql/item_strfunc.h
> > @@ -1748,5 +1748,20 @@ class Item_func_dyncol_list: public Item_str_func
> >    { return get_item_copy<Item_func_dyncol_list>(thd, this); }
> >  };
> >  
> > -#endif /* ITEM_STRFUNC_INCLUDED */
> 
> Please add a note that this is not the "_rowid" that we support in the parser.

I used the terminology that you introduced, that is
"keep_current_rowid".

But if you don't mind, I'd rather rename keep_current_rowid (and
every "rowid" that I introduced) to keep_current_position (because it's
handler::position()) or keep_current_ref (because it's handler::ref and
handler::ref_length), whichever is less ambiguous.

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx