maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Oleksandr!

On Apr 20, Oleksandr Byelkin wrote:
> revision-id: 331034cb6e1552e1ab7c12b6f7341f557f76b807 (mariadb-10.3.6-16-g331034cb6e1)
> parent(s): cff60be7fe159fdcb2517ce8441610ad512aa7d0
> author: Oleksandr Byelkin
> committer: Oleksandr Byelkin
> timestamp: 2018-04-20 14:40:14 +0200
> message:
> 
> MDEV-11975: SQLCOM_PREPARE of EXPLAIN & ANALYZE statement do not return correct metadata info
> 
> Added metadate info after prepare EXPLAIN/ANALYZE.
> 
> diff --git a/sql/sql_class.cc b/sql/sql_class.cc
> index 96485ed15ec..0ec95e11829 100644
> --- a/sql/sql_class.cc
> +++ b/sql/sql_class.cc
> @@ -2659,18 +2659,32 @@ CHANGED_TABLE_LIST* THD::changed_table_dup(const char *key, size_t key_length)
>  }
>  
>  
> -int THD::send_explain_fields(select_result *result, uint8 explain_flags, bool is_analyze)
> +void THD::prepare_explain_fields(select_result *result,
> +                                 List<Item> *field_list,
> +                                 uint8 explain_flags,
> +                                 bool is_analyze)
>  {
> -  List<Item> field_list;
> +  ;

forgot to remove?

otherwise, ok to push...

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx