maria-developers team mailing list archive

Thread
Date

Re: bea915f: MDEV-15965 Invisible columns and LOAD DATA don't work well together:...

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Mon, 7 May 2018 16:41:09 +0200
In-reply-to: <20180426111948.30A8DD2072E@sachin-desk.localdomain>
User-agent: Mutt/1.7.2 (2016-11-26)

Hi, sachin!

On Apr 26, sachin wrote:
> revision-id: bea915f21a2a2771ce7f9e19dcb9d6893f33f7bd (mariadb-10.3.6-47-gbea915f)
> parent(s): 326db1a2aaa9b275a1a21a863e8cd2d9fa1b1d5f
> author: Sachin Setiya
> committer: Sachin Setiya
> timestamp: 2018-04-26 16:49:27 +0530
> message:
> 
> MDEV-15965 Invisible columns and LOAD DATA don't work well together:...
> ER_WARN_TOO_FEW_RECORDS
> 
> Fix mysql_load iterator to skip invisible fields.
> 
> diff --git a/sql/sql_load.cc b/sql/sql_load.cc
> index cfa92f1..fbb3926 100644
> --- a/sql/sql_load.cc
> +++ b/sql/sql_load.cc
> @@ -444,6 +444,8 @@ int mysql_load(THD *thd, const sql_exchange *ex, TABLE_LIST *table_list,
>      field_iterator.set(table_list);
>      for (; !field_iterator.end_of_fields(); field_iterator.next())
>      {
> +      if (field_iterator.field()->invisible > VISIBLE)
> +        continue;

Oh, that's all? And the syntax with SET just worked automatically?
Cool.

ok to push!

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx