maria-developers team mailing list archive

Thread
Date

Re: 6be8bd6: MDEV-15890 Strange error message if you try to FLUSH TABLES <view> after LOCK TABLES <view>.

To: maria-developers@xxxxxxxxxxxxxxxxxxx
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 31 Aug 2018 15:08:27 +0200
Cc: holyfoot@xxxxxxxxxxx
In-reply-to: <20180624191356.90B95140C61@nebo.localdomain>
User-agent: Mutt/1.7.2 (2016-11-26)

Hi, Alexey!

On Jun 24, Alexey Botchkov wrote:
> revision-id: 6be8bd6ee05c6f18b6a6a0375f9bc2b68ef6c43e (mariadb-10.3.7-59-g6be8bd6)
> parent(s): 1abd877e2df9e83bc1c2f5195796f427a35bd3f1
> committer: Alexey Botchkov
> timestamp: 2018-06-24 23:12:20 +0400
> message:
> 
> MDEV-15890 Strange error message if you try to FLUSH TABLES <view> after LOCK TABLES <view>.
> 
> Check if the argument of the FLUSH TABLE is a VIEW and handle it
> accordingly.

Looks great!

But please add more tests. A test with a write lock, and tests with
locking the view and flushing the table or vice versa.

After that ok to push!

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx