maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexey!

On Oct 30, Alexey Botchkov wrote:
>  > What if both arguments will be zeros, but have intg=DIG_PER_DEC1-1.
> > Won't the result have more that DIG_PER_DEC1 zeros?
> 
> Leading zero 'digits' are truncated, so we never get more than DIG_PER_DEC
> there. Actually we don't need to do that check at all (intg <=
> DIG_PER_DEC1),
> i removed it already.

Put it in an assert please.
I find asserts quite useful as a documentation tool :)

Then ok to push!

Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx