maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Alexey!

We've already discussed the solution, so ok to push.

But it's a bit weird to have "mdev17148" in the std_data,
could you rename it to mdev17148.frm?

Or, even better, don't check in a binary file, but do instead

  create table t1 (a int);
  copy_file $datadir/test/t1.frm $datadir/db1/T1.frm;

std_data is for files that cannot be easily created in the test. Like a
.frm file from mysql-4.0.

On Dec 24, Alexey Botchkov wrote:
> revision-id: 54411ba5caee35d0a64e727c117c222b6eef8812 (mariadb-10.2.19-98-g54411ba)
> parent(s): 975f4a1295f2b678c5ecea2cf4cfc69e177d88f5
> committer: Alexey Botchkov
> timestamp: 2018-12-24 16:41:16 +0400
> message:
> 
> MDEV-17148 DROP DATABASE throw "Directory not empty" after changed lower_case_table_names.
> 
> No need to lowercase table names on case-sensitive file systems, as the
> cache won't contain the 'lowercased' table anyway. And it prevents the
> UPPERCASE.frm from being deleted.
> 
>  mysql-test/r/lowercase_table.result |   2 ++
>  mysql-test/std_data/mdev17148       | Bin 0 -> 433 bytes
>  mysql-test/t/lowercase_table.test   |  10 ++++++++++
>  sql/sql_db.cc                       |   8 ++++++--
>  4 files changed, 18 insertions(+), 2 deletions(-)
> 
Regards,
Sergei
Chief Architect MariaDB
and security@xxxxxxxxxxx