← Back to team overview

maria-developers team mailing list archive

Re: ce4f8955d8d: MDEV-17082 Application period tables: CREATE

 

Hi, Sergei!

On Wed, Jan 30, 2019 at 7:33 AM Sergei Golubchik <serg@xxxxxxxxxxx> wrote:

> Hi, Nikita!
>
> On Jan 30, Nikita Malyavin wrote:
> > >
> > > In a similar case I used something like
> > >
> > > #define SIZE 2
> > > #define uintSIZEkorr(X) uint2korr(X)
> > >
> > > This way there are no magically-looking numbers. You can even
> > > write `uint ## SIZE ## korr`, if you're feeling adventurous.
> > >
> > Thanks for advice! Looks suitable enough
> > I will just make #define korr2size 2. But it should be shared between
> > table.cc and unireg.cc.
> > Can You suggest me where to put it?
>
> As you like. table.h, perhaps?
>
> Sounds good ✅

Thanks for the review!

-- 
Yours truly,
Nikita Malyavin

References