maria-developers team mailing list archive

Thread
Date

Re: 044dfaff670: Replace handler::primary_key_is_clustered() with handler::ha_is_clustered_key()

To: Michael Widenius <monty@xxxxxxxxxxx>
From: Sergei Golubchik <serg@xxxxxxxxxxx>
Date: Fri, 28 Feb 2020 12:59:33 +0100
Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
In-reply-to: <JhAReBCuzGH.A.8RH.Z1PWeB@pweza>
User-agent: Mutt/1.10.1 (2018-07-13)

Hi, Michael!

On Feb 28, Michael Widenius wrote:
> revision-id: 044dfaff670 (mariadb-10.5.0-275-g044dfaff670)
> parent(s): 5ae74b4823a
> author: Michael Widenius <monty@xxxxxxxxxxx>
> committer: Michael Widenius <monty@xxxxxxxxxxx>
> timestamp: 2020-02-26 16:05:55 +0200
> message:
> 
> Replace handler::primary_key_is_clustered() with handler::ha_is_clustered_key()
> 
> This was done to both simplify the code and also to be easier to handle
> storage engines that are clustered on some other index than the primary
> key.

No, I don't get it.
Old method meant "Check if the key is a clustered and a reference key".

Just "clustered" is marked with HA_CLUSTERED_INDEX.

So,

1. You've renamed the method but the name does not match the semantics.
   It is called is_clustering_key() but it really means
   "clustered AND reference key"

2. What other engine can be where the reference key isn't a primary key?

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx