maria-developers team mailing list archive
Mailing list archive
Re: 7740cb24572: Don't use plugin->data for storage engine plugins
On Tue, Mar 31, 2020 at 02:15:34PM +0200, Sergei Golubchik wrote:
> Hi, Sergey!
> On Mar 31, Sergey Vojtovich wrote:
> > revision-id: 7740cb24572 (mariadb-10.4.4-472-g7740cb24572)
> > parent(s): da6d7f72b0a
> > author: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> > committer: Sergey Vojtovich <svoj@xxxxxxxxxxx>
> > timestamp: 2019-11-15 15:23:42 +0400
> > message:
> > Don't use plugin->data for storage engine plugins
> > Use plugin->plugin->info->hton instead.
> > plugin_data() replaced with plugin_hton().
Because plugin->data is becoming redundant with declarative approach introduced
in the parent revision.
> > plugin_hton() must never return NULL anymore and is only good to be called
> > against plugins in PLUGIN_IS_READY state.
Because there was just one use case when it wasn't enforced:
iter_schema_engines(). And it was trivially fixed.
> Why is that?
> VP of MariaDB Server Engineering
> and security@xxxxxxxxxxx