maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Michael!

On May 20, Michael Widenius wrote:
> revision-id: b22a28c2295 (mariadb-10.5.2-256-gb22a28c2295)
> parent(s): acbe14b122c
> author: Michael Widenius <monty@xxxxxxxxxxx>
> committer: Michael Widenius <monty@xxxxxxxxxxx>
> timestamp: 2020-05-19 17:52:18 +0300
> message:
> 
> fixup! 3fe5cd5e1785e3e8de7add9977a1c2ddd403538b
> 
> MDEV-22607 Assertion `ha_info->ht() != binlog_hton' failed in
>            MYSQL_BIN_LOG::unlog_xa_prepare
> 
> diff --git a/sql/log.cc b/sql/log.cc
> index 7e9e231358a..792c6bb1a99 100644
> --- a/sql/log.cc
> +++ b/sql/log.cc
> @@ -10128,11 +10128,6 @@ int TC_LOG_BINLOG::unlog_xa_prepare(THD *thd, bool all)
>      if (rw_count > 0)
>      {
>        /* an empty XA-prepare event group is logged */
> -#ifndef DBUG_OFF
> -      for (ha_info= thd->transaction->all.ha_list; rw_count > 1 && ha_info;
> -           ha_info= ha_info->next())
> -        DBUG_ASSERT(ha_info->ht() != binlog_hton);
> -#endif
>        rc= write_empty_xa_prepare(thd, cache_mngr); // normally gains need_unlog
>        trans_register_ha(thd, true, binlog_hton, 0); // do it for future commmit
>      }

What does this assertion mean and what does it mean that it no longer
holds?

Regards,
Sergei