maria-developers team mailing list archive

[Sergei Golubchik <serg@xxxxxxxxxxx>]

Hi, Dmitry!

On Oct 22, Dmitry Shulga wrote:
> revision-id: 2830b9c290e (mariadb-10.2.31-489-g2830b9c290e)
> parent(s): 8984d779103
> author: Dmitry Shulga <dmitry.shulga@xxxxxxxxxxx>
> committer: Dmitry Shulga <dmitry.shulga@xxxxxxxxxxx>
> timestamp: 2020-10-22 00:42:10 +0700
> message:
> 
> MDEV-23926: Fix warnings generated during compilation of plugin/auth_pam/mapper/pam_user_map.c on MacOS
> 
> Compiler warnings like one listed below are generated during server build on MacOS:
> 
> 
> ---
>  plugin/auth_pam/CMakeLists.txt        | 26 ++++++++++++++++++++++++++
>  plugin/auth_pam/config.h.cmake        |  1 +
>  plugin/auth_pam/mapper/pam_user_map.c | 30 +++++++++++++++++++-----------
>  3 files changed, 46 insertions(+), 11 deletions(-)

Nice!

Could you also - in a second follow-up commit, not to confuse with the
pure bug fix - do a small cleanup and move all other checks from
plugin/auth_pam/CMakeLists.txt into your new config.h.cmake ?

Currently they're added to the command line, like

  IF(HAVE_PAM_EXT_H)
    ADD_DEFINITIONS(-DHAVE_PAM_EXT_H)
  ENDIF()

but as you've introduced config.h.cmake, there's no need to put them all
on the command line anymore. You'll need to include config_auth_pam.h
into more source files. And, I suppose. add config_auth_pam.h to
.gitignore too.

ok to push these two commits when done. Thanks!

Regards,
Sergei
VP of MariaDB Server Engineering
and security@xxxxxxxxxxx