← Back to team overview

maria-developers team mailing list archive

Re: 77500a1a1107: Added typedef decimal_digits_t (uint16) for number of decimals

 

Hi, Michael!

I did not get any reply to my email

  From: Sergei Golubchik <serg@xxxxxxxxxxx>
  To: Michael Widenius <michael.widenius@xxxxxxxxx>
  Cc: maria-developers@xxxxxxxxxxxxxxxxxxx
  Subject: Re: c79c6f78205: Added typedef decimal_digits_t (uint16) for number of decimals
  Date: Wed, 9 Sep 2020 13:34:57 +0200

and I don't see any related changes in this commit.
Please, do at least one of the two.

Regards,
Sergei

On Dec 03, Michael Widenius wrote:
> revision-id: 77500a1a1107 (mariadb-10.5.2-268-g77500a1a1107)
> parent(s): 32104b969513
> author: Michael Widenius <michael.widenius@xxxxxxxxx>
> committer: Michael Widenius <michael.widenius@xxxxxxxxx>
> timestamp: 2020-09-17 12:24:58 +0300
> message:
> 
> Added typedef decimal_digits_t (uint16) for number of decimals
> 
> For fields and Item's uint8 should be good enough. After
> discussions with Alexander Barkov we choose uint16 (for now)
> as some format functions may accept +256 digits.
> 
> The reason for this patch was to make the storage of decimal
> digits simlar. Before this patch decimals was stored/used as
> uint8, int and uint.
> 
> Changed most decimal variables and functions to use the new
> typedef.
>